Conversation
tobymao
force-pushed
the
toby/jinja
branch
2 times, most recently
from
ad20245 to
3362e9a
Compare
Collaborator
|
Looks good at first glance. Let me know if there are any outstanding items I can help with. |
tobymao
force-pushed
the
toby/jinja
branch
2 times, most recently
from
10bce56 to
616cd8c
Compare
izeigerman
reviewed
Dec 13, 2022
| ON oi.item_id = i.id AND oi.ds = i.ds | ||
| WHERE | ||
| oi.ds BETWEEN @start_ds AND @end_ds | ||
| oi.ds BETWEEN '{{ start_ds }}' AND '{{ end_ds }}' |
Collaborator
There was a problem hiding this comment.
noooooooooooooooooooooo 🤮 😆
izeigerman
reviewed
Dec 13, 2022
| ) | ||
|
|
||
| with pytest.raises(ConfigError) as ex: | ||
| with pytest.raises(ValidationError) as ex: |
Collaborator
There was a problem hiding this comment.
I don' think we should let the jinja error out. We should intercept it and raise the ConfigError instead which would in turn contain a path to a model file where the error occurred.
Collaborator
There was a problem hiding this comment.
See the _raise_config_error usage in Model.load
izeigerman
reviewed
Dec 13, 2022
izeigerman
reviewed
Dec 13, 2022
izeigerman
approved these changes
Dec 13, 2022
Collaborator
izeigerman
left a comment
izeigerman
left a comment
There was a problem hiding this comment.
Few smaller comments, LGTM otherwise
izeigerman
reviewed
Dec 13, 2022
|
|
||
| def __init__(self, definition: str = "", **kwargs): | ||
| meta, *expressions = parse(definition, read=kwargs.get("dialect")) | ||
| meta, *expressions = d.parse_model( |
Collaborator
There was a problem hiding this comment.
Btw, I'm planning to refactor this decorator to use Model.load instead.
Contributor
Author
There was a problem hiding this comment.
sounsd good, let me get this in first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.